Horton

Re: Fix gcc warning in sync.c (usr/src/backend/storage/sync/sync.c)

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Ranier Vilela <ranier.vf@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-07-21T18:01:43Z
Lists: pgsql-hackers 
On 2022-Jul-15, Thomas Munro wrote:

> On Mon, Jul 11, 2022 at 9:45 PM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:

> > So, for starters, I compiled the whole tree with -Wshadow=local. and I
> > saw many warnings with it.  At a glance all of them are reasonably
> > "fixed" but I don't think it is what we want...
> 
> Wow, yeah.

Previous threads on this topic:

https://postgr.es/m/MN2PR18MB2927F7B5F690065E1194B258E35D0@MN2PR18MB2927.namprd18.prod.outlook.com
https://postgr.es/m/CAApHDvpqBR7u9yzW4yggjG=QfN=FZsc8Wo2ckokpQtif-+iQ2A@mail.gmail.com
https://postgr.es/m/877k1psmpf.fsf@mailbox.samurai.com

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
Thou shalt study thy libraries and strive not to reinvent them without
cause, that thy code may be short and readable and thy days pleasant
and productive. (7th Commandment for C Programmers)

Commits

  1. Avoid shadowing a variable in sync.c.