Horton

Re: make -C libpq check fails obscurely if tap tests are disabled

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Date: 2022-07-21T08:53:48Z
Lists: pgsql-hackers

Attachments

On 2022-Jul-20, Andrew Dunstan wrote:

> On 2022-07-20 We 13:23, Justin Pryzby wrote:
> > PATH=... && @echo "TAP tests not enabled. Try configuring with --enable-tap-tests"
> > /bin/sh: 1: @echo: not found
> >
> > make is telling the shell to run "@echo" , rather than running "echo" silently.

> Yeah. It's a bit ugly but I think the attached would fix it.

Here's a different take.  Just assign the variable separately.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"No renuncies a nada. No te aferres a nada."

Commits

  1. Increase minimum supported GNU make version to 3.81.

  2. Fix [install]check in interfaces/libpq/Makefile

  3. Run tap tests in src/interfaces/libpq.