Horton

Re: pgsql: Default to hidden visibility for extension libraries where possi

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-committers@lists.postgresql.org
Date: 2022-07-19T13:18:01Z
Lists: pgsql-hackers 
On 2022-Jul-19, Pavel Stehule wrote:

> po 18. 7. 2022 v 3:06 odesílatel Andres Freund <andres@anarazel.de> napsal:
> 
> > Default to hidden visibility for extension libraries where possible

> Unfortunately, this commit definitely breaks plpgsql_check. Can the
> following routines be visible?

Do you just need to send a patch to add an exports.txt file to
src/pl/plpgsql/src/ for these functions?

plpgsql_build_datatype
plpgsql_compile
plpgsql_parser_setup
plpgsql_stmt_typename
plpgsql_exec_get_datum_type
plpgsql_recognize_err_condition
plpgsql_ns_lookup

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

Commits

  1. Add PGDLLEXPORTS to some plpgsql function declarations

  2. Default to hidden visibility for extension libraries where possible

  3. Expose a few more PL/pgSQL functions to debugger plugins.