Re: pgsql: Default to hidden visibility for extension libraries where possi

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Date: 2022-07-18T02:01:55Z
Lists: pgsql-hackers
On 2022-07-17 18:39:35 -0700, Andres Freund wrote:
> On 2022-07-18 01:05:56 +0000, Andres Freund wrote:
> > Default to hidden visibility for extension libraries where possible
>
> Looking at the odd failures, not sure what went wrong.

I don't know how the configure exec bit got removed, shell history doesn't
show anything odd in that regard. I do see a mistake in locally merging the
symbol-visibility branch (leading to a crucial commit being missed). I do see
in shell history that I ran check-world without a failure just before pushing,
which should have shown the failure, but didn't.

Definitely a brown paper bag moment.



Commits

  1. Add PGDLLEXPORTS to some plpgsql function declarations

  2. Default to hidden visibility for extension libraries where possible

  3. Expose a few more PL/pgSQL functions to debugger plugins.