Re: fix stats_fetch_consistency value in postgresql.conf.sample
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, nathandbossart@gmail.com, pgsql-hackers@postgresql.org
Date: 2022-07-13T23:49:00Z
Lists: pgsql-hackers
Hi, On 2022-07-14 08:46:02 +0900, Michael Paquier wrote: > On Wed, Jul 13, 2022 at 12:30:00PM -0500, Justin Pryzby wrote: > > How did you make this list ? Was it by excluding things that failed for you ? > > > > cfbot is currently failing due to io_concurrency on windows. > > I think there are more GUC which should be included here. > > > > http://cfbot.cputube.org/kyotaro-horiguchi.html > > FWIW, I am not really a fan of making this test depend on a hardcoded > list of GUCs. I wonder if we should add flags indicating platform dependency etc to guc.c? That should allow to remove most of them? > The design strength of the existing test is that we > don't have such a dependency now, making less to think about in terms > of maintenance in the long-term, even if this is now run > automatically. There's no existing test for things covered by these exceptions, unless I am missing something? Greetings, Andres Freund
Commits
-
Align stats_fetch_consistency definition with guc.c default.
- 0107855b1480 15.0 landed
-
Fix stats_fetch_consistency default value indicated in postgresql.conf.sample.
- 98f897339b01 15.0 landed