DropRelFileLocatorBuffers
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Date: 2022-07-07T08:44:36Z
Lists: pgsql-hackers
Hello. While working on a patch, I met a function with the signature of: > DropRelFileLocatorBuffers(SMgrRelation smgr_reln, ForkNumber *forkNum, > int nforks, BlockNumber *firstDelBlock) It was DropRelFileNodeBuffers(), which means "Drop buffers for a RelFileNode", where RelFileNode means a storage or a (set of) file(s). In that sense, "Drop buffers for a RelFile*Locator*" sounds a bit off to me. Isn't it better change the name? RelFileLocator doesn't look to be fit here. "DropRelFileBuffers" works better at least for me.. If it does, some other functions need the same amendment. Thought? regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Rename some functions to mention Relation instead of RelFileLocator.
- 09c5acee8ef9 16.0 landed
-
Fix mistake in comment.
- b2d5b4c6e09b 16.0 landed
-
Change internal RelFileNode references to RelFileNumber or RelFileLocator.
- b0a55e43299c 16.0 cited