Horton

Re: Probable memory leak with ECPG and AIX

Noah Misch <noah@leadboat.com>

View thread View on postgr.es
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Guillaume Lelarge <guillaume@lelarge.info>, Benoit Lobréau <benoit.lobreau@gmail.com>, PostgreSQL Developers <pgsql-hackers@postgresql.org>, "Dr. Michael Meskes" <michael.meskes@credativ.com>
Date: 2022-07-04T05:59:22Z
Lists: pgsql-hackers 
On Sat, Jul 02, 2022 at 11:59:58PM -0400, Tom Lane wrote:
> Confirmed that either initializing ecpg_clocale or adding -fno-common
> allows the ecpglib build to succeed.  (Testing it beyond that would
> require another hour or so to build the rest of the system, so I won't.)
> 
> As I said, I was already leaning to the idea that initializing the
> variable explicitly is better style, so I recommend we do that.

Works for me.  Pushed that way, and things have been clean.

Commits

  1. Fix previous commit's ecpg_clocale for ppc Darwin.

  2. ecpglib: call newlocale() once per process.