Re: Inconvenience of pg_read_binary_file()
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: michael@paquier.xyz
Cc: pgsql-hackers@postgresql.org
Date: 2022-06-30T01:59:52Z
Lists: pgsql-hackers
Attachments
- v3-0001-Add-an-argument-variation-to-pg_read_file.patch (text/x-patch)
At Tue, 07 Jun 2022 17:29:31 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in > pg_read_file(text, bool) makes sense to me, but it doesn't seem like > to be able to share C function with other variations. > pg_read_binary_file() need to accept some out-of-range value for > offset or length to signal that offset and length are not specified. In this version all the polypmorphic variations share the same body function. I tempted to add tail-reading feature but it would be another feature. > (function comments needs to be edited and docs are needed) - Simplified the implementation (by complexifying argument handling..). - REVOKEd EXECUTE from the new functions. - Edited the signature of the two functions. > - pg_read_file ( filename text [, offset bigint, length bigint [, missing_ok boolean ]] ) → text > + pg_read_file ( filename text [, offset bigint, length bigint ] [, missing_ok boolean ] ) → text And registered this to the next CF. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Adjust new pg_read_file() test cases for more portability.
- d10fad96c664 16.0 landed
-
Support pg_read_[binary_]file (filename, missing_ok).
- 283129e325b7 16.0 landed