Re: PG15 beta1 fix pg_stats_ext/pg_stats_ext_exprs view manual
Justin Pryzby <pryzby@telsasoft.com>
From: Justin Pryzby <pryzby@telsasoft.com>
To: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>
Cc: pgsql-hackers@postgresql.org, Tomas Vondra <tomas.vondra@enterprisedb.com>
Date: 2022-06-14T14:30:06Z
Lists: pgsql-hackers
On Tue, May 24, 2022 at 08:19:27PM -0500, Justin Pryzby wrote: > On Wed, May 25, 2022 at 01:08:12AM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote: > > Hi hackers, > > Thanks to all the developers. The attached patch updates the manual for the pg_stats_ext and pg_stats_ext_exprs view. > > The current pg_stats_ext/pg_stats_ext_exprs view manual are missing the inherited column. This column was added at the same time as the stxdinherit column in the pg_statistic_ext_data view. The attached patch adds the missing description. If there is a better description, please correct it. > > > > Commit: Add stxdinherit flag to pg_statistic_ext_data > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=269b532aef55a579ae02a3e8e8df14101570dfd9 > > Current Manual: > > https://www.postgresql.org/docs/15/view-pg-stats-ext.html > > https://www.postgresql.org/docs/15/view-pg-stats-ext-exprs.html > > Thanks for copying me. > > This looks right, and uses the same language as pg_stats and pg_statistic. > > But, I'd prefer if it didn't say "inheritance child", since that now sounds > like it means "a child which is using inheritance" and not just "any child". > > I'd made a patch for that, for which I'll create a separate thread shortly. The thread I started [0] has stalled out, so your patch seems seems fine, since it's consistent with pre-existing docs. [0] https://www.postgresql.org/message-id/20220525013248.GO19626@telsasoft.com -- Justin
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
doc: Mention attribute "inherited" in pg_stats_ext[_exprs]
- 401f623c7b14 15.0 landed
-
Add stxdinherit flag to pg_statistic_ext_data
- 269b532aef55 15.0 cited