Re: pg_rewind: warn when checkpoint hasn't happened after promotion
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: jtc331@gmail.com
Cc: bharath.rupireddyforpostgres@gmail.com, pgsql-hackers@postgresql.org
Date: 2022-06-08T09:15:09Z
Lists: pgsql-hackers
Attachments
- pg_rewind_fix_2.diff.txt (text/plain)
At Tue, 07 Jun 2022 16:05:47 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in > At Tue, 07 Jun 2022 12:39:38 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in > > One possible way to detect promotion reliably is to look into timeline > > history files. It is written immediately at promotion even on > > standbys. > > The attached seems to work. It uses timeline history files to identify > the source timeline. With this change pg_waldump no longer need to > wait for end-of-recovery to finish. > > (It lacks doc part and test.. But I'm not sure how we can test this > behavior.) This is a revised version. Revised getTimelineHistory()'s logic (refactored, and changed so that it doesn't pick-up the wrong history files). perform_rewind always identify endtli based on source's timeline history. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
pg_rewind: Remove notice in docs about running CHECKPOINT after promote.
- 0a0500207a94 16.0 landed
-
pg_rewind: Fix determining TLI when server was just promoted.
- 009eeee74682 16.0 cited