Re: Error from the foreign RDBMS on a foreign table I have no privilege on
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: tgl@sss.pgh.pa.us
Cc: laurenz.albe@cybertec.at, euler@eulerto.com, philflorent@hotmail.com,
pgsql-hackers@lists.postgresql.org
Date: 2022-06-08T04:08:16Z
Lists: pgsql-hackers
At Tue, 07 Jun 2022 23:04:52 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote in > Laurenz Albe <laurenz.albe@cybertec.at> writes: > > On Wed, 2022-06-08 at 11:12 +0900, Kyotaro Horiguchi wrote: > > RangeTblEntry *rte = root->simple_rte_array[i]; > > aclcheck_error(ACLCHECK_NO_PRIV, > > get_relkind_objtype(rte->relkind), > > get_rel_name(rte->relid)); > > I think it's completely inappropriate for FDWs to be taking it on > themselves to inject privilege checks. The system design is that > that is checked at executor start; not before, not after. Ah, yes. It's not good that checking it at multiple stages, and the only one place should be executor start. regards. -- Kyotaro Horiguchi NTT Open Source Software Center