Re: pg15b1: FailedAssertion("val > base", File: "...src/include/utils/relptr.h", Line: 67, PID: 30485)
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: robertmhaas@gmail.com
Cc: tgl@sss.pgh.pa.us, pryzby@telsasoft.com,
pgsql-hackers@lists.postgresql.org, thomas.munro@gmail.com
Date: 2022-06-01T02:51:33Z
Lists: pgsql-hackers
Attachments
- make-relptr-allow-zero-address.patch (text/x-patch) patch
At Tue, 31 May 2022 15:57:14 -0400, Robert Haas <robertmhaas@gmail.com> wrote in > 1. Using a relative pointer value other than 0 to represent a null > pointer. Andres suggested (Size) -1. I thought that relptr as a part of DSM so the use of offset=0 is somewhat illegal. But I like this. We can fix this by this modification. I think ((Size) -1) is natural to signal something special. (I see glibc uses "(size_t) -1".) > 2. Not storing the free page manager for the DSM in the main shared > memory segment at byte offset 0. > 3. Dropping the assertion while loudly singing "la la la la la la". reagards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Fix relptr's encoding of the base address.
- 99504ff8265e 14.5 landed
- 7201cd18627a 15.0 landed
-
Suppress compiler warning in relptr_store().
- e07d4ddc55fd 15.0 cited