Horton

Re: BUG #17485: Records missing from Primary Key index when doing REINDEX INDEX CONCURRENTLY

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Andrey Borodin <x4mmm@yandex-team.ru>, Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Петър Славов <pet.slavov@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2022-05-31T08:53:45Z
Lists: pgsql-bugs 
On 2022-May-31, Michael Paquier wrote:

> On Mon, May 30, 2022 at 10:43:41PM +0200, Alvaro Herrera wrote:
> > This is the full reversal in branch master.
> 
> This looks fine to me, thanks.  I can see that you have kept the
> reference to ComputeXidHorizons for vacuum_defer_cleanup_age in
> guc.c.

Yeah, there was a typo fix there that I also kept as well as one newline
change.  Basically I scanned the reversal patch manually and removed the
changes I thought were better kept.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"El miedo atento y previsor es la madre de la seguridad" (E. Burke)

Commits

  1. Revert changes to CONCURRENTLY that "sped up" Xmin advance

  2. Fix possible HOT corruption when RECENTLY_DEAD changes to DEAD while pruning.