Horton

Thread

Commits

  1. Remove useless tests for TRUNCATE on foreign tables

  1. Remove useless tests about TRUNCATE on foreign table

    Yugo Nagata <nagata@sraoss.co.jp> — 2022-05-27T08:25:43Z

    Hello,

I found that tests for TRUNCATE on foreign tables are left
in the foreign_data regression test. Now TRUNCATE on foreign
tables are allowed, so I think the tests should be removed.

Currently, the results of the test is 
 "ERROR:  foreign-data wrapper "dummy" has no handler",
but it is just because the foreign table has no handler,
not due to TRUNCATE.

The patch is attached.

Regards,
Yugo Nagata

-- 
Yugo NAGATA <nagata@sraoss.co.jp>

  2. Re: Remove useless tests about TRUNCATE on foreign table

    Michael Paquier <michael@paquier.xyz> — 2022-05-30T08:08:10Z

    On Fri, May 27, 2022 at 05:25:43PM +0900, Yugo NAGATA wrote:
> --- TRUNCATE doesn't work on foreign tables, either directly or recursively
> -TRUNCATE ft2;  -- ERROR
> -ERROR:  foreign-data wrapper "dummy" has no handler
> -TRUNCATE fd_pt1;  -- ERROR
> -ERROR:  foreign-data wrapper "dummy" has no handler
>  DROP TABLE fd_pt1 CASCADE;

In the case of this test, fd_pt1 is a normal table that ft2 inherits,
so this TRUNCATE command somewhat checks that the TRUNCATE falls back
to the foreign table in this case.  However, this happens to be tested
in postgres_fdw (see around tru_ftable_parent),

> --- TRUNCATE doesn't work on foreign tables, either directly or recursively
> -TRUNCATE fd_pt2_1;  -- ERROR
> -ERROR:  foreign-data wrapper "dummy" has no handler
> -TRUNCATE fd_pt2;  -- ERROR
> -ERROR:  foreign-data wrapper "dummy" has no handler

Partitions have also some coverage as far as I can see, so I agree
that it makes little sense to keep the tests you are removing here.
--
Michael

  3. Re: Remove useless tests about TRUNCATE on foreign table

    Michael Paquier <michael@paquier.xyz> — 2022-05-31T00:49:40Z

    On Mon, May 30, 2022 at 05:08:10PM +0900, Michael Paquier wrote:
> Partitions have also some coverage as far as I can see, so I agree
> that it makes little sense to keep the tests you are removing here.

And done as of 0efa513.
--
Michael

  4. Re: Remove useless tests about TRUNCATE on foreign table

    Yugo Nagata <nagata@sraoss.co.jp> — 2022-05-31T09:11:20Z

    On Tue, 31 May 2022 09:49:40 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> On Mon, May 30, 2022 at 05:08:10PM +0900, Michael Paquier wrote:
> > Partitions have also some coverage as far as I can see, so I agree
> > that it makes little sense to keep the tests you are removing here.
> 
> And done as of 0efa513.

Thank you!


-- 
Yugo NAGATA <nagata@sraoss.co.jp>