Re: "ERROR: latch already owned" on gharial

Noah Misch <noah@leadboat.com>

From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>, CM Team <cm@enterprisedb.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-05-25T06:46:58Z
Lists: pgsql-hackers
On Tue, May 24, 2022 at 06:24:39PM -0700, Andres Freund wrote:
> On 2022-05-25 12:45:21 +1200, Thomas Munro wrote:
> > Just BTW, that animal has shown signs of a flaky toolchain before[1].
> > I know we have quite a lot of museum exhibits in the 'farm, in terms
> > of hardare, OS, and tool chain.  In some cases, they're probably just
> > forgotten/not on anyone's upgrade radar.  If they've shown signs of
> > misbehaving, maybe it's time to figure out if they can be upgraded?
> > For example, it'd be nice to be able to rule out problems in GCC 4.6.0
> > (that's like running PostgreSQL 9.1.0, in terms of vintage,
> > unsupported status, and long list of missing bugfixes from the time
> > when it was supported).
> 
> Yea. gcc 4.6.0 is pretty ridiculous - the only thing we gain by testing with a
> .0 compiler of that vintage is pain. Could it be upgraded?

+1, this is at least the third non-obvious miscompilation from gharial.
Installing the latest GCC that builds easily (perhaps GCC 10.3) would make
this a good buildfarm member again.  If that won't happen, at least add a note
to the animal like described in
https://postgr.es/m/20211109144021.GD940092@rfd.leadboat.com



Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add debugging help in OwnLatch().

  2. Add barriers to the latch code.