Re: tweak to a few index tests to hits ambuildempty() routine.
Noah Misch <noah@leadboat.com>
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-05-21T06:15:09Z
Lists: pgsql-hackers
Attachments
- stream-regress-unlogged-v1.patch (text/plain) patch v1
On Mon, Apr 25, 2022 at 10:05:08AM -0400, Tom Lane wrote: > Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > > Hmm, so 027_stream_regress.pl is not prepared to deal with any unlogged > > tables that may be left in the regression database (which is what my > > spgist addition did). I first tried doing a TRUNCATE of the unlogged > > table, but that doesn't work either, and it turns out that the > > regression database does not have any UNLOGGED relations. Maybe that's > > something we need to cater for, eventually, but for now dropping the > > table suffices. I have pushed that. > > It does seem like the onus should be on 027_stream_regress.pl to > deal with that, rather than restricting what the core tests can > leave behind. Yeah. Using "pg_dumpall --no-unlogged-table-data", as attached, suffices. > Maybe we could have it look for unlogged tables and drop them > before making the dumps? Although I don't understand why > TRUNCATE wouldn't do the job equally well. After TRUNCATE, one still gets a setval for sequences and a zero-row COPY for tables. When dumping a standby or using --no-unlogged-table-data, those commands are absent.
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Avoid loss of code coverage with unlogged-index test cases.
- 7a84c35fe6dc 15.0 landed
- 1d2fec990c4d 16.0 landed
-
Use --no-unlogged-table-data in t/027_stream_regress.pl.
- 2f2e24d90c40 15.0 landed
-
Cover brin/gin/gist/spgist ambuildempty routines in regression tests
- 4fb5c794e586 15.0 landed
-
Improve test coverage of ginvacuum.c.
- 4c51a2d1e4b7 14.0 cited