Horton

Declaration fixes

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org
Date: 2022-05-12T16:45:13Z
Lists: pgsql-hackers

Attachments

Hi,

I was experimenting with specifying symbol visiblity for functions explicitly,
i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid of
src/tools/msvc/gendef.pl (and similar AIX stuff). While doing that I compared
the set of exported symbols before / after, leading me to find a few
pre-existing "issues".

I think the attached patches are all a good idea and trivial enought that I
think we should apply them now.

The changes are sufficiently obvious and/or explained in the commit messages.

Comments?

Greetings,

Andres Freund

Commits

  1. Add 'static' to file-local variables missing it.

  2. Add missing 'extern' to function prototypes.

  3. Add missing binary_upgrade.h includes.

  4. Remove function declaration for function in pg_proc.