Horton

Re: testclient.exe installed under MSVC

Noah Misch <noah@leadboat.com>

View thread View on postgr.es
From: Noah Misch <noah@leadboat.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, Jacob Champion <pchampion@vmware.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-05-03T13:50:38Z
Lists: pgsql-hackers 
On Tue, May 03, 2022 at 03:04:26PM +0200, Daniel Gustafsson wrote:
> > On 3 May 2022, at 04:02, Noah Misch <noah@leadboat.com> wrote:
> > On Mon, May 02, 2022 at 03:14:50PM +0200, Daniel Gustafsson wrote:
> 
> >> Renaming is probably the best option given how MSVC works. Using a pg_ prefix
> >> makes them sound like actual useful tools though with (albeit small) risk for
> >> confusion? Noah's suggestion of libpq_ is perhaps better: libpq_testclient.
> > 
> > Agreed. libpq_testclient and libpq_uri_regress sound fine.
> 
> The attached works in both Linux and (Cirrus CI) MSVC for me.

Michael Paquier recommended s/-/_/ for uri-regress, and I agree with that.
What do you think?

Commits

  1. Add Windows file version information to libpq/test programs.

  2. Rename libpq test programs with libpq_ prefix

  3. Build libpq test programs under MSVC

  4. Enable SSL library detection via PQsslAttribute()