Horton

Re: [RFC] building postgres with meson -v8

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Date: 2022-04-21T20:56:37Z
Lists: pgsql-hackers 
Hi,

On 2022-04-21 22:36:01 +0200, Peter Eisentraut wrote:
> On 20.04.22 23:04, Andres Freund wrote:
> > > 0003-Fix-warnings-about-deprecated-features.patch
> > > 
> > > This fixes some deprecation warnings and raises the requirement to 0.56.
> > 
> > I don't see any deprecation warnings - I see some notices about *future*
> > deprecated features being used:
> > 
> > NOTICE: Future-deprecated features used:
> >   * 0.55.0: {'ExternalProgram.path'}
> >   * 0.56.0: {'meson.source_root', 'meson.build_root'}
> > 
> > (i.e. once the minimum version is increased to > 0.54, those will trigger
> > deprecation warnings)
> > 
> > What are you seeing with what version?
> 
> I see the same thing.  Effectively, "deprecation warning" and
> "future-deprecation notice" are just different spellings of "yelling at me
> unconditionally for using code that I can't do anything about".

Yea, I'm not happy that "future-deprecation notice" was enabled by
default. It's still different from "deprecation warning" in prominence and
behaviour (e.g. --fatal-meson-warnings doesn't error out for notices but not
for errors), but ...

Might be worth raising with the meson folks.


> > > I'm not sure why the current cutoff at 0.54 was chosen.  Perhaps that could
> > > be documented.
> > 
> > Not quite sure why I ended up with 0.54. We definitely should require at most
> > 0.56, as that's the last version supporting python 3.5.
> 
> Why is Python 3.5 relevant?

It's the latest available on some older platforms. It's pretty easy to install
a new meson, a heck of a lot more work to install a new python. IIRC solaris,
AIX and some of Tom's dinosaurs.


> > >  From 1f80e1ebb8efeb0eba7d57032282520fd6455b0d Mon Sep 17 00:00:00 2001
> > > From: Peter Eisentraut <peter@eisentraut.org>
> > > Date: Wed, 13 Apr 2022 11:50:52 +0200
> > > Subject: [PATCH 5/5] Workaround for Perl detection
> > > 
> > > ---
> > >   meson.build | 6 +++---
> > >   1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/meson.build b/meson.build
> > > index 1bf53ea24d..e33ed11b08 100644
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -545,9 +545,9 @@ else
> > >     # file existence.
> > >     if perl_may_work
> > >       perl_ccflags += ['-I@0@'.format(perl_inc_dir)]
> > > -    if host_machine.system() == 'darwin'
> > > -      perl_ccflags += ['-iwithsysroot', perl_inc_dir]
> > > -    endif
> > > +    #if host_machine.system() == 'darwin'
> > > +    #  perl_ccflags += ['-iwithsysroot', perl_inc_dir]
> > > +    #endif
> > >     endif
> > 
> > What problem do you see without this? It did build on CI and on my m1 mini box
> > as is...
> 
> I'm using homebrew-installed gcc and homebrew-installed perl.  gcc doesn't
> understand the option -iwithsysroot, and apparently whatever it points to is
> not needed.

Ah, I only tested with system "cc".


> Note that in configure.ac the logic is like this:
> 
>   if test \! -f "$perl_archlibexp/CORE/perl.h" ; then
>     if test -f "$PG_SYSROOT$perl_archlibexp/CORE/perl.h" ; then
>       perl_includespec="-iwithsysroot $perl_archlibexp/CORE"
>     fi
>   fi
> 
> So it checks first if it can find the needed file without the sysroot
> business.

I guess we'll have to copy that. Although it doesn't seem quite the right
behaviour, because it might end up picking up a different perl.h that way...

Greetings,

Andres Freund

Commits

  1. meson: Add 'running' test setup, as a replacement for installcheck

  2. meson: Add support for building with precompiled headers

  3. windows: Adjust FD_SETSIZE via commandline define

  4. meson: docs: Add xml{lint,proc} wrapper to collect dependencies

  5. meson: ecpg: Split definition of static and shared libraries

  6. windows: Set UMDF_USING_NTSTATUS globally, include ntstatus.h

  7. ci: Add hint about downloadable logs to README

  8. meson: Set up absolute rpaths to libdir

  9. meson: Include CFLAGS/c_args in summary and pg_config output

  10. windows: remove date from version number in win32ver.rc

  11. meson: Add initial version of meson based build system

  12. ci: windows: set error mode to not include SEM_NOGPFAULTERRORBOX

  13. Refactor PG_TEST_EXTRA logic in autoconf build

  14. Split TESTDIR into TESTLOGDIR and TESTDATADIR

  15. Don't hardcode tmp_check/ as test directory for tap tests

  16. Extend gendef.pl in preparation for meson

  17. Include c.h instead of postgres.h in src/port/*p{read,write}*.c

  18. Remove DLLTOOL, DLLWRAP from configure / Makefile.global.in

  19. Run xmllint validation only once

  20. Bump minimum Perl version to 5.14

  21. Move gramparse.h to src/backend/parser

  22. Run perltidy over Catalog.pm

  23. Parse catalog .dat files as a whole when compiling the backend

  24. Build all Flex files standalone

  25. Move private declarations shared between guc.c and guc-file.l to new header

  26. Preparatory refactoring for compiling guc-file.c standalone

  27. Move darwin sysroot determination into separate file

  28. Fix MSVC warning in compat_informix/rnull.pgc

  29. solaris: Use versioning scripts instead of -Bsymbolic

  30. Change shared library installation naming on macOS

  31. regress: allow to specify directory containing expected files, for ecpg

  32. Don't add HAVE_LDAP_H HAVE_WINLDAP_H to pg_config.h

  33. Refactor dtrace postprocessing make rules

  34. Add output directory option to gen_node_support.pl

  35. Add output directory argument to generate-unicode_norm_table.pl

  36. Add output file argument to generate-errcodes.pl

  37. Add output path arg in generate-lwlocknames.pl

  38. Move snowball_create.sql creation into perl file

  39. ecpg: Output dir, source dir, stamp file argument for preproc/*.pl

  40. psql: Output dir and dependency generation for sql_help

  41. Deal with paths containing \ and spaces in basebackup_to_shell tests

  42. Remove LLVM_CONFIG from Makefile.global.in

  43. Make update-unicode target work in vpath builds

  44. Refactor DLSUFFIX handling

  45. ldap tests: Add paths for openbsd.

  46. ldap tests: Don't run on unsupported operating systems.

  47. Remove check for accept() argument types

  48. Move our p{read,write}v replacements into their own files.

  49. Adjust yywrap macro for non-reentrant scanners for MSVC.

  50. Remove any -arch switches given in ExtUtils::Embed's ldopts from our

  51. Change PL/Perl and Pg interface build to use configured compiler and

  52. Apparently, on some systems, ExtUtils::Embed and MakeMaker are slightly