Horton

Re: Postgres perl module namespace

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew@dunslane.net>, Erik Rijkers <er@xs4all.nl>, Noah Misch <noah@leadboat.com>, Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Mark Dilger <mark.dilger@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-04-18T14:44:29Z
Lists: pgsql-hackers 
Hi,

On 2022-04-18 10:26:15 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I just, again, tried to backport a test as part of a bugfix. The
> > renaming between 14 and 15 makes that task almost comically harder. The
> > only way I see of dealing with that for the next 5 years is to just
> > never backpatch tests to < 15. Which seems like a bad outcome.
> 
> Yeah ...
> 
> > Except that it's *way* too late I would argue that this should just
> > straight up be reverted until that aspect is addressed. It's a
> > maintenance nightmare.
> 
> I'm not for that

I'm not either, at this point...


> but could it be sane to back-patch the renaming?

That might be the best.  But it might not even suffice. There've been
other global refactorings between 14 and 15. E.g. 201a76183e2.

I wonder if we should just backpatch the current PostgreSQL module, but
leave the old stuff around :/.

Greetings,

Andres Freund

Commits

  1. Fix PostgreSQL::Test aliasing for Perl v5.10.1.

  2. For PostgreSQL::Test compatibility, alias entire package symbol tables.

  3. Make PostgresNode easily subclassable