Re: Add --{no-,}bypassrls flags to createuser
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: Shinya11.Kato@oss.nttdata.com
Cc: daniel@yesql.se, robertmhaas@gmail.com, michael@paquier.xyz,
pgsql-hackers@postgresql.org
Date: 2022-04-15T06:33:41Z
Lists: pgsql-hackers
At Fri, 15 Apr 2022 14:55:48 +0900, Shinya Kato <Shinya11.Kato@oss.nttdata.com> wrote in
> I understand. For backward compatibility, I left the ROLE clause
> option as it is and changed the IN ROLE clause option to --membership
> option.
Thanks!
- printf(_(" -g, --role=ROLE new role will be a member of this role\n"));
+ printf(_(" -g, --role=ROLE new role will be a member of this role\n"));
This looks lik an unexpected change. We shoudl preserve it, but *I*
think that we can add a synonym of the old --role for
understandability/memorability. (By the way "-g" looks like coming
from "group", which looks somewhat strange..)
> printf(_(" -b, --belongs-to=ROLE new role will be a member of this role\n"));
+ printf(_(" -m, --membership=ROLE this role will be a member of new role\n"));
membership sounds somewhat obscure, it seems *to me* members is clearer
> printf(_(" -m, --member=ROLE new role will be a member of this role\n"));
I'd like to hear others' opinions.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix output of createuser --help with --valid-until
- 4ca998595788 16.0 landed
-
createuser: Add support for more clause types through new options
- 08951a7c93cf 16.0 landed
-
createuser: Cleanup and fix internal option ordering
- 50e4c280f066 16.0 landed
-
Add REPLICATION privilege for ROLEs
- 9b8aff8c192e 9.1.0 cited