Horton

Re: typos

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: David Rowley <dgrowleyml@gmail.com>, pgsql-hackers@postgresql.org, Fabien COELHO <coelho@cri.ensmp.fr>
Date: 2022-04-13T17:40:56Z
Lists: pgsql-hackers

Attachments

On Wed, Apr 13, 2022 at 07:29:34PM +0200, Alvaro Herrera wrote:
> On 2022-Apr-11, David Rowley wrote:
> 
> > and also skipped:
> > 0016 (unsure if we should change these of pgindent is not touching it)
> > 0017 (unsure if we should change these of pgindent is not touching it)
> 
> I verified that pgindent will indeed not touch these changes by running
> before and after.  (I accepted one comment placement from that run that
> touched a neighboring line.)
> 
> I think pgindent is right not to modify vertical space very much, since
> in many cases it amounts to a subjective decision.  The patch seemed a
> (small) improvement, and it seems hard to make too much of a fuss about
> such things.  Pushed them as a single commit.
> 
> I hadn't noticed that Justin had posted a refreshed patch series, so I
> don't know if the new ones match what I pushed.

There were no changes - I had resent the patches that removed blank lines so it
was apparent that they were "outstanding" / under discussion.

There's (only) a few remaining.

Commits

  1. Fix typos and grammar in code and test comments

  2. Standardize references to Zstandard as <productname>

  3. CREATE PUBLICATION ref: Minor tweaks to row filters

  4. Add missing spaces after single-line comments

  5. Docs: fix some spelling mistakes and also do some wordsmithing

  6. Remove extraneous blank lines before block-closing braces

  7. Docs: wording improvement for compute_query_id = regress

  8. Docs: tidy up various usages of the productname tag

  9. Docs: adjust wording about basebackup_to_shell's required_role GUC

  10. Docs: adjust pg_upgrade syntax to mark -B as optional

  11. Docs: avoid confusing use of the word "synchronized"

  12. Fix grammatical errors and typos in logical replication docs.

  13. Docs: Mention that relpersistence is for sequences now too

  14. Fix various typos and spelling mistakes in code comments

  15. Docs: Fix various mistakes and typos