Re: test/isolation/expected/stats_1.out broken for me

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: chap@anastigmatix.net, pgsql-hackers@lists.postgresql.org
Date: 2022-04-07T22:02:45Z
Lists: pgsql-hackers
Hi,

On 2022-04-07 09:57:09 -0700, Andres Freund wrote:
> Yea :(. I tested debug_discard_caches, but not -DRELCACHE_FORCE_RELEASE
> -DCATCACHE_FORCE_RELEASE.
> 
> Not quite sure what to do about it - it's intentionally trying to test the
> case of no invalidations being processed, as that's an annoying edge case with
> functions.  Perhaps wrapping the function call of the "already dropped"
> function in another function that catches the error would do the trick? It'd
> be more easily silently broken, but still be better than not having the test.

Anybody got a better idea?

- Andres



Commits

  1. pgstat: Hide instability in stats.spec with -DCATCACHE_FORCE_RELEASE.

  2. Fix test instability introduced in e349c95d3e9 due to async deduplication.