Horton

Re: Naming of the different stats systems / "stats collector"

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: 2022-04-04T04:22:59Z
Lists: pgsql-hackers 
Hi,

On 2022-03-08 20:17:06 -0700, David G. Johnston wrote:
> On Tue, Mar 8, 2022 at 7:32 PM Andres Freund <andres@anarazel.de> wrote:
> 
> > we need a descriptive term / shorthand that
> > describes the type of statistics we currently send to the stats collector.
> >
> > "cumulative stats subsystem"?
> >
> >
> I'm growing fond of "cumulative".  It is more precise (and restrictive)
> than "metric" but that is beneficial here so long as it is indeed true
> (which a quick skim of Table 28.2. Collected Statistics Views [1] leads me
> to believe it is).

I did go for that one - I think it looks better than the other
alternatives. Should you be interested, I posted a version using that name at
[1]. The majority of the changes related to the naming are in 0005, 0026,
0028...

Greetings,

Andres Freund

[1] https://www.postgresql.org/message-id/20220404041516.cctrvpadhuriawlq%40alap3.anarazel.de

Commits

  1. pgstat: store statistics in shared memory.

  2. pgstat: stats collector references in comments.

  3. pgstat: consistent function comment formatting.