Horton

Re: Higher level questions around shared memory stats

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Fujii Masao <fujii@postgresql.org>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, melanieplageman@gmail.com
Date: 2022-04-03T11:34:00Z
Lists: pgsql-hackers 
On 2022-Apr-02, Andres Freund wrote:

> 6) Should any part of the "reuse_stats" logic in table_recheck_autovac() be
> kept?
> 
> With the shared memory stats patch, autovacuum can cheaply access individual
> stats, so the whole scheme for avoiding stats accesses is moot.

Agreed, I don't think there's need to keep any of that.

> I don't really see a point in keeping any of it - but I was curious whether
> anybody else does?

I don't either.

> I'm still polishing, so I didn't want to send a whole new version with these
> adjustments to the list yet, but you can see the state as of the time of
> sending this email at [1].

I'll have a look, thanks.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

Commits

  1. pgstat: remove stats_temp_directory.

  2. pgstat: consistent function comment formatting.