Horton

Re: windows cfbot failing: my_perl

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: John Naylor <john.naylor@enterprisedb.com>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Justin Pryzby <pryzby@telsasoft.com>, John Naylor <john.naylor@postgresql.org>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@gmail.com>
Date: 2022-08-26T20:32:15Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> Tom, Ilmari, you seem to have hacked on this stuff most (not so) recently. Do
> you have a better suggestion than moving the mb/pg_wchar.h include out of
> plperl_helpers.h as I suggest below?

I agree with the conclusion that we'd better #include all our own
headers before any of Perl's.  No strong opinions about which
rearrangement is least ugly --- but let's add some comments about
that requirement.

			regards, tom lane

Commits

  1. Be more careful to avoid including system headers after perl.h

  2. Use SSE2 in is_valid_ascii() where available.