Horton
Menu

Re: Column Filtering in Logical Replication

Justin Pryzby <pryzby@telsasoft.com>

View thread
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Amit Kapila <amit.kapila16@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Rahila Syed <rahilasyed90@gmail.com>, Peter Smith <smithpb2250@gmail.com>, pgsql-hackers@postgresql.org
Date: 2021-12-31T16:32:27Z
Lists: pgsql-hackers 
> @@ -5963,8 +5967,20 @@ describePublications(const char *pattern)
>  		{
>  			/* Get the tables for the specified publication */
>  			printfPQExpBuffer(&buf,
> -							  "SELECT n.nspname, c.relname\n"
> -							  "FROM pg_catalog.pg_class c,\n"
> +							  "SELECT n.nspname, c.relname, \n");
> +			if (pset.sversion >= 150000)
> +				appendPQExpBufferStr(&buf,
> +									 "       CASE WHEN pr.prattrs IS NOT NULL THEN\n"
> +									 "       pg_catalog.array_to_string"
> +									 "(ARRAY(SELECT attname\n"
> +									 "         FROM pg_catalog.generate_series(0, pg_catalog.array_upper(pr.prattrs::int[], 1)) s,\n"
> +									 "              pg_catalog.pg_attribute\n"
> +									 "        WHERE attrelid = c.oid AND attnum = prattrs[s]), ', ')\n"
> +									 "       ELSE NULL END AS columns");
> +			else
> +				appendPQExpBufferStr(&buf, "NULL as columns");
> +			appendPQExpBuffer(&buf,
> +							  "\nFROM pg_catalog.pg_class c,\n"
>  							  "     pg_catalog.pg_namespace n,\n"
>  							  "     pg_catalog.pg_publication_rel pr\n"
>  							  "WHERE c.relnamespace = n.oid\n"

I suppose this should use pr.prattrs::pg_catalog.int2[] ?

Did the DatumGetBool issue expose a deficiency in testing ?
I think the !am_partition path was never being hit.

-- 
Justin

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Explain about Column List feature.

  2. Doc: fix column list vs. replica identity rules.

  3. Prohibit combining publications with different column lists.

  4. Fix the check to limit sync workers.

  5. Wait for subscription to sync in t/031_column_list.sql

  6. Move prattrs to the pg_publication_rel section in docs

  7. Allow specifying column lists for logical replication

  8. Fix row filters with multiple publications

  9. Fix publish_as_relid with multiple publications

  10. Add some additional tests for row filters in logical replication.

  11. Add index on pg_publication_rel.prpubid

  12. Avoid using DefElemAction in AlterPublicationStmt

  13. Small cleanups related to PUBLICATION framework code

  14. Add PublicationTable and PublicationRelInfo structs

  15. Fix various concurrency issues in logical replication worker launching