Re: Add index scan progress to pg_stat_progress_vacuum
Justin Pryzby <pryzby@telsasoft.com>
From: Justin Pryzby <pryzby@telsasoft.com>
To: "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Peter Geoghegan <pg@bowt.ie>, "Bossart, Nathan" <bossartn@amazon.com>, pgsql-hackers@postgresql.org
Date: 2021-12-29T17:51:21Z
Lists: pgsql-hackers
http://cfbot.cputube.org/sami-imseih.html You should run "make check" and update rules.out. You should also use make check-world - usually something like: make check-world -j4 >check-world.out 2>&1 ; echo ret $? > indrelid: The relid of the index currently being vacuumed I think it should be called indexrelid not indrelid, for consistency with pg_index. > S.param10 vacuum_cycle_ordinal_position, > S.param13 index_rows_vacuumed These should both say "AS" for consistency. system_views.sql is using tabs, but should use spaces for consistency. > #include "commands/progress.h" The postgres convention is to alphabetize the includes. > /* VACCUM operation's longest index scan cycle */ VACCUM => VACUUM Ultimately you'll also need to update the docs.
Commits
-
Report index vacuum progress.
- 46ebdfe164c6 17.0 landed
-
Add new parallel message type to progress reporting.
- f1889729dd3a 17.0 landed
-
Remove MaxBackends variable in favor of GetMaxBackends() function.
- aa64f23b0292 15.0 cited