Horton

Re: pg_dump versus ancient server versions

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Andrew Dunstan <andrew@dunslane.net>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Bruce Momjian <bruce@momjian.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@lists.postgresql.org
Date: 2021-12-16T04:58:04Z
Lists: pgsql-hackers 
On Wed, Dec 15, 2021 at 10:08:07PM -0600, Justin Pryzby wrote:
> Is it possible to clean up pg_upgrade, too ?

Nevermind - I found yesterday's e469f0aaf3 after git-fetch.

I think you missed a few parts though ?

src/bin/pg_upgrade/function.c
                if (GET_MAJOR_VERSION(old_cluster.major_version) <= 900)
...
                        if (GET_MAJOR_VERSION(old_cluster.major_version) <= 900 &&
                                strcmp(lib, "$libdir/plpython") == 0)

src/bin/pg_upgrade/option.c
                                 * Someday, the port number option could be removed and passed
                                 * using -o/-O, but that requires postmaster -C to be
                                 * supported on all old/new versions (added in PG 9.2).
...
        if (GET_MAJOR_VERSION(cluster->major_version) >= 901)

Commits

  1. Remove psql support for server versions preceding 9.2.

  2. Clean up some more freshly-dead code in pg_dump and pg_upgrade.

  3. Remove pg_dump's --no-synchronized-snapshots switch.

  4. Remove pg_upgrade support for upgrading from pre-9.2 servers.

  5. Remove pg_dump/pg_dumpall support for dumping from pre-9.2 servers.

  6. Suppress -Warray-bounds warning in 9.2's xlog.c.

  7. Suppress -Wformat-overflow warnings in 9.2's xml.c.

  8. Disable -Wsometimes-uninitialized warnings in the 9.2 branch.

  9. Fix function return type confusion

  10. Fix compiler warning

  11. Silence another gcc 11 warning.

  12. Suppress uninitialized-variable warning in guc.c.

  13. Suppress -Warray-parameter warnings in pgcrypto/sha2.c.

  14. Reformat imath.c macro to remove -Wmisleading-indentation warnings.

  15. Clean up compilation warnings coming from PL/Perl with clang-12~

  16. Make ecpg's rjulmdy() and rmdyjul() agree with their declarations.

  17. Use -Wno-format-truncation and -Wno-stringop-truncation, if available.

  18. Make pg_upgrade's test.sh less chatty.

  19. Add checks for valid multibyte character length in UtfToLocal, LocalToUtf.

  20. Use return instead of exit() in configure

  21. Add support for Visual Studio 2019 in build scripts