Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-11T22:51:58Z
Lists: pgsql-hackers
Hi, On 2021-12-11 13:13:56 -0800, Peter Geoghegan wrote: > On Sat, Dec 11, 2021 at 12:24 PM Andres Freund <andres@anarazel.de> wrote: > > But the ereport is inside an if (verbose), no? > > Yes -- in order to report aggressiveness in VACUUM VERBOSE. But the > autovacuum case still reports verbose-ness, in the same way as it > always has -- in that same LOG entry. We don't want to repeat > ourselves in the VERBOSE case, which will have already indicated its > verboseness in the up-front ereport(). I feel one, or both, must be missing something here. My point was that you said upthread that the patch doesn't change DEBUG2/non-verbose logging for most messages. But the fact that those messages are only emitted inside and if (verbose) seems to contradict that? Greetings, Andres Freund
Commits
-
Unify VACUUM VERBOSE and autovacuum logging.
- 49c9d9fcfa9a 15.0 landed