Re: Correct handling of blank/commented lines in PSQL interactive-mode history
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Greg Nancarrow <gregn4422@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Laurenz Albe <laurenz.albe@cybertec.at>, "David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-11-30T21:26:53Z
Lists: pgsql-hackers
On Mon, Nov 29, 2021 at 11:12:35PM -0500, Tom Lane wrote: > Greg Nancarrow <gregn4422@gmail.com> writes: > > After a bit of investigation, it seems that patch attachments (like > > yours) with a Context-Type of "text/x-diff" download through Gmail in > > CRLF format for me (I'm running a browser on Windows, but my Postgres > > development environment is in a Linux VM). So those must get converted > > from Unix to CRLF format if downloaded using a browser running on > > Windows. > > The majority of patch attachments (?) seem to have a Context-Type of > > "application/octet-stream" or "text/x-patch", and these seem to > > download raw (in their original Unix format). > > Interesting. I can probably adjust my MUA to send "text/x-patch", > but I'll have to look around to see where that's determined. > (I dislike using "application/octet-stream" for this, because > the archives won't show that as text, they only let you download > the attachment. Maybe that's more Safari's fault than the > archives per se, not sure.) I would be interesting to know if "text/x-patch" is better than "text/x-diff" --- I currently use the later. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.
Commits
-
psql: initialize comment-begin setting to a useful value by default.
- 3d858af07ee6 15.0 landed
-
psql: treat "--" comments between queries as separate history entries.
- c2f654930e9f 15.0 landed
-
psql: include intra-query "--" comments in what's sent to the server.
- 83884682f4df 15.0 landed