Re: BUG #17288: PSQL bug with COPY command (Windows)

On Thu, Nov 25, 2021 at 12:23:41PM +0900, Michael Paquier wrote:
> On Wed, Nov 24, 2021 at 10:44:09AM +0300, Dmitry Koval wrote:
> > Unfortunately, you are.
> > All my COPY-tests work well with files.
> > I see a problem in the terminal only ...
> 
> While checking all the callers of fstat() in the core code, I have
> discovered that this broke a second case when stdout is not
> redirected: pg_recvlogical -f -.  In this case, the code would just
> bump on EINVAL repeatedly instead of crashing, but equally broken it
> was.  There is a TAP test for this case in src/bin/pg_basebackup/, but
> it would not trigger the problem per the redirection already done
> there.
> 
> Anyway, I have run more tests, tweaked slightly the comment, and
> applied it down to 14.  Thanks to both of you!

Do you know this causes a new warning ?

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2021-11-29%2004%3A00%3A29

Nov 28 23:06:41 c:/mingw/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.build/../pgsql/src/port/win32stat.c:309:3: warning: implicit declaration of function 'GetFinalPathNameByHandleA'; did you mean 'GetFullPathNameA'? [-Wimplicit-function-declaration]
...

-- 
Justin