Horton

Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-11-26T21:57:12Z
Lists: pgsql-hackers 
On Fri, Nov 26, 2021 at 12:37:32PM -0800, Peter Geoghegan wrote:
> My preferred approach to this is simple: redefine VACUUM VERBOSE to
> not show incremental output, which seems rather unhelpful anyway.

> I don't think that we need to keep the getrusage() stuff at all, though.

+1

> * VACUUM VERBOSE doesn't provide much of the most useful
> instrumentation that we have available in log_autovacuum_min_duration,
> and yet produces output that is ludicrously, unmanageably verbose --
> lots of pg_rusage_show() information for each and every step, which
> just isn't useful.

Not only not useful/unhelpful, but confusing.

It's what I complained about here.
https://www.postgresql.org/message-id/flat/20191220171132.GB30414@telsasoft.com

I see that lazy_scan_heap() still has a shadow variable buf...

-- 
Justin

Commits

  1. Unify VACUUM VERBOSE and autovacuum logging.