Re: Some RELKIND macro refactoring
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-11-23T15:36:15Z
Lists: pgsql-hackers
On 2021-Nov-23, Alvaro Herrera wrote:
> On 2021-Nov-22, Peter Eisentraut wrote:
>
> > Maybe
> >
> > else
> > {
> > Assert(RELKIND_HAS_STORAGE(rel->rd_rel->relkind);
> > RelationCreateStorage(rel->rd_node, relpersistence);
> > }
> >
> > create_storage is set earlier based on RELKIND_HAS_STORAGE(), so this would
> > be consistent.
>
> Hmm, right ... but I think we can make this a little simpler. How about
> the attached?
This doesn't actually work, so nevermind that.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
Essentially, you're proposing Kevlar shoes as a solution for the problem
that you want to walk around carrying a loaded gun aimed at your foot.
(Tom Lane)
Commits
-
Some RELKIND macro refactoring
- 37b2764593c0 15.0 landed
-
pg_dump: Add missing relkind case
- a22d6a2cb62c 15.0 landed
-
Fix handling of partitioned index in RelationGetNumberOfBlocksInFork()
- 0d906b2c0b1f 15.0 landed