Re: Some RELKIND macro refactoring

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es

From: Alvaro Herrera <alvherre@alvh.no-ip.org>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2021-11-23T15:19:13Z

Lists: pgsql-hackers

Attachments

create-storage.patch (text/x-diff) patch

On 2021-Nov-22, Peter Eisentraut wrote:

> Maybe
> 
>     else
>     {
>         Assert(RELKIND_HAS_STORAGE(rel->rd_rel->relkind);
>         RelationCreateStorage(rel->rd_node, relpersistence);
>     }
> 
> create_storage is set earlier based on RELKIND_HAS_STORAGE(), so this would
> be consistent.

Hmm, right ... but I think we can make this a little simpler.  How about
the attached?

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/

Commits

Some RELKIND macro refactoring
- 37b2764593c0 15.0 landed
pg_dump: Add missing relkind case
- a22d6a2cb62c 15.0 landed
Fix handling of partitioned index in RelationGetNumberOfBlocksInFork()
- 0d906b2c0b1f 15.0 landed