Horton

Re: Windows build warnings

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Greg Nancarrow <gregn4422@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-11-22T14:21:15Z
Lists: pgsql-hackers 
On 2021-Nov-22, Daniel Gustafsson wrote:

> > On 22 Nov 2021, at 12:10, Greg Nancarrow <gregn4422@gmail.com> wrote:
> 
> > I've attached a patch to fix these warnings.
> 
> LGTM.

.. but see
https://postgr.es/m/CAH2-WznwWU+9on9nZCnZtk7uA238MCTgPxYr1Ty7U_Msn5ZGwQ@mail.gmail.com
where this was already discussed.  I think if we're going to workaround
PG_USED_FOR_ASSERTS_ONLY not actually working, we may as well get rid of
it entirely.  My preference would be to fix it so that it works on more
platforms (at least Windows in addition to GCC).

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/
"In Europe they call me Niklaus Wirth; in the US they call me Nickel's worth.
 That's because in Europe they call me by name, and in the US by value!"

Commits

  1. Disable unused-variable warning C4101 in MSVC

  2. Remove PF_USED_FOR_ASSERTS_ONLY from variables in general use

  3. Fix handling of non-key columns get_index_column_opclass()