Horton

Re: Parallel Full Hash Join

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Greg Nancarrow <gregn4422@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, pgsql-hackers@postgresql.org
Date: 2021-11-21T03:48:48Z
Lists: pgsql-hackers 
On Wed, Nov 17, 2021 at 01:45:06PM -0500, Melanie Plageman wrote:
> On Sat, Nov 6, 2021 at 11:04 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> >
> > > Rebased patches attached. I will change status back to "Ready for Committer"
> >
> > The CI showed a crash on freebsd, which I reproduced.
> > https://cirrus-ci.com/task/5203060415791104
> >
> > The crash is evidenced in 0001 - but only ~15% of the time.
> >
> > I think it's the same thing which was committed and then reverted here, so
> > maybe I'm not saying anything new.
> >
> > https://commitfest.postgresql.org/33/3031/
> > https://www.postgresql.org/message-id/flat/20200929061142.GA29096@paquier.xyz
> 
> Yes, this looks like that issue.
> 
> I've attached a v8 set with the fix I suggested in [1] included.
> (I added it to 0001).

This is still crashing :(
https://cirrus-ci.com/task/6738329224871936
https://cirrus-ci.com/task/4895130286030848

-- 
Justin

Commits

  1. Remove overzealous assertion from PHJ.

  2. Remove comment obsoleted by 11c2d6fd.

  3. Parallel Hash Full Join.

  4. Improve the naming of Parallel Hash Join phases.

  5. Update the names of Parallel Hash Join phases.

  6. Add BarrierArriveAndDetachExceptLast().

  7. Mop-up for wait event naming issues.

  8. Push tuple limits through Gather and Gather Merge.