Horton

Re: Should we improve "PID XXXX is not a PostgreSQL server process" warning for pg_terminate_backend(<<postmaster_pid>>)?

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Euler Taveira <euler@eulerto.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2021-11-17T19:13:02Z
Lists: pgsql-hackers 
On Wed, Nov 17, 2021 at 03:59:59PM -0300, Euler Taveira wrote:
> On Mon, Nov 15, 2021, at 4:27 AM, Bharath Rupireddy wrote:
> > As there is some interest shown in this thread at [1], I'm attaching a
> > new v3 patch here. Please review it.
> I took a look at this patch. I have a few comments.
> 
> + ereport(WARNING,
> + (errmsg("signalling postmaster with PID %d is not allowed", pid)));
> 
> I would say "signal postmaster PID 1234 is not allowed". It is not an
> in-progress action.

It's correct to say "signalling ... is not allowed", which means the same as
"it is not allowed to signal ...".

-- 
Justin

Commits

  1. Improve warning message in pg_signal_backend()