Horton

Re: pg_upgrade test chatter

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "Bossart, Nathan" <bossartn@amazon.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-10-20T02:37:28Z
Lists: pgsql-hackers 
On 2021-Oct-19, Tom Lane wrote:

> Yeah, my original thought had been to hack this at the test level.
> However, I felt like it'd be worth adding this code because we could
> apply it elsewhere in pg_regress.c to save several psql sessions
> (and hence backend starts) per regression DB creation.  That's not a
> huge win, but it'd add up.

Ah, yeah, that sounds like it can be significant under valgrind and
such, so +1.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)

Commits

  1. Improve pg_regress.c's infrastructure for issuing psql commands.