Re: ldap/t/001_auth.pl fails with openldap 2.5

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Peter Eisentraut <peter_e@gmx.net>, Thomas Munro <tmunro@postgresql.org>
Date: 2021-10-19T18:20:16Z
Lists: pgsql-hackers
Hi,

On 2021-10-10 00:45:41 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Although I'm mildly tempted to rewrap the parameters, it's kinda odd how the
> > trailing parameter on one line, has its value on the next line.
> 
> I'm betting that perltidy did that.  If you want to fix it so it
> stays fixed, maybe reordering the parameters could help.

You were right on that front. Since perltidy insisted on reflowing due to the
reduction in number of parameters anyway, I did end up switching things around
so that the parameters look a bit more reasonable.

> > So, does anybody see a reason not to go for the trivial
> > [ patch ]
> 
> I'd be happy to rely on the buildfarm's opinion here.

Let's see what it says...

Greetings,

Andres Freund



Commits

  1. Adapt src/test/ldap/t/001_auth.pl to work with openldap 2.5.