Horton

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

Noah Misch <noah@leadboat.com>

View thread View on postgr.es
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Craig Ringer <craig.ringer@enterprisedb.com>
Date: 2021-10-10T02:25:53Z
Lists: pgsql-hackers 
On Sat, Oct 09, 2021 at 04:34:46PM -0400, Tom Lane wrote:
> Hah ... your backpan link led me to realize the actual problem with
> Test::More.  It got folded into Test::Simple at some point, and
> evidently cpanm isn't smart enough to handle a request for a back
> version in such cases.  But this works:
> 
> $ cpanm install Test::Simple@0.87_01
> ...
> $ perl -MTest::More -e 'print $Test::More::VERSION, "\n";'
> 0.8701
> 
> So we oughta recommend that instead.  Now I'm wondering what
> version of IPC::Run to recommend.

You mentioned prairiedog uses IPC::Run 0.79.  That's from 2005.  (Perl 5.8.3
is from 2004, and Test::More 0.87 is from 2009.)  I'd just use 0.79 in the
README recipe.  IPC::Run is easy to upgrade, so if we find cause to rely on a
newer version, I'd be fine updating that requirement.

Commits

  1. Make configure check for minimum required version of IPC::Run.

  2. Doc: update testing recipe in src/test/perl/README.

  3. Update test/perl/README to insist on Perl version >= 5.8.3, too.

  4. Adjust configure to insist on Perl version >= 5.8.3.

  5. Doc: specify that the minimum supported version of Perl is 5.8.3.