Horton

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Craig Ringer <craig.ringer@enterprisedb.com>, Noah Misch <noah@leadboat.com>
Date: 2021-10-07T22:39:17Z
Lists: pgsql-hackers 
On 2021-Oct-07, Tom Lane wrote:

> +Portability
> +-----------
> +
> +Avoid using any bleeding-edge Perl features.  We have buildfarm animals
> +running Perl versions as old as 5.8.3, so your tests will be expected
> +to pass on that.
> +
> +Also, do not use any non-core Perl modules except IPC::Run.  Or, if you
> +must do so for a particular test, arrange to skip the test when the needed
> +module isn't present.  If unsure, you can consult Module::CoreList to find
> +out whether a given module is part of the Perl core, and which module
> +versions shipped with which Perl releases.

LGTM, thanks.

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)

Commits

  1. Make configure check for minimum required version of IPC::Run.

  2. Doc: update testing recipe in src/test/perl/README.

  3. Update test/perl/README to insist on Perl version >= 5.8.3, too.

  4. Adjust configure to insist on Perl version >= 5.8.3.

  5. Doc: specify that the minimum supported version of Perl is 5.8.3.