Horton

Re: Incorrect snapshots while promoting hot standby node when 2PC is used

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org, Michael Paquier <michael.paquier@gmail.com>, Simon Riggs <simon@2ndquadrant.com>, Thomas Munro <thomas.munro@gmail.com>
Date: 2021-10-06T06:09:41Z
Lists: pgsql-hackers 
On 2021-10-04 17:27:44 +0900, Michael Paquier wrote:
> On Fri, Oct 01, 2021 at 02:11:15PM +0900, Michael Paquier wrote:
> > A couple of months later, I have looked back at this thread and this
> > report.  I have rechecked all the standby handling and snapshot builds
> > involving KnownAssignedXids and looked at all the phases that are
> > getting called until we call ShutdownRecoveryTransactionEnvironment()
> > to release these, and I don't think that there is a problem with the
> > solution proposed here.  So I propose to move on and apply this
> > patch.  Please let me know if there are any objections.
> 
> Okay, I have worked more on that today, did more tests and applied the
> fix as of 8a42379.

Thanks for remembering this!

Commits

  1. Fix snapshot builds during promotion of hot standby node with 2PC