Horton

Re: BUG #16160: Minor memory leak in case of starting postgres server with SSL encryption

Stephen Frost <sfrost@snowman.net>

View thread View on postgr.es
From: Stephen Frost <sfrost@snowman.net>
To: Andres Freund <andres@anarazel.de>
Cc: Jelte Fennema <postgres@jeltef.nl>, Michael Paquier <michael@paquier.xyz>, duspensky@ya.ru, pgsql-bugs@lists.postgresql.org
Date: 2021-03-21T14:32:21Z
Lists: pgsql-bugs 
Greetings,

* Andres Freund (andres@anarazel.de) wrote:
> On 2021-03-16 14:44:55 -0400, Stephen Frost wrote:
> > OOMs errors should be gracefully handled and PG should continue to
> > function.  Was that not the case..?
> 
> Depends on what you mean with graceful. Unless you restart the database
> you'll eventually not be able to do anything anymore, since even the
> smallest memory allocation will fail?

Bit confused- I certainly agree with fixing the leak and back-patching
it, not sure how it came across otherwise.  I was asking the questions
that I was to try to figure out if there was some other issue at play as
well.

Thanks,

Stephen

Commits

  1. Fix memory leak when rejecting bogus DH parameters.

  2. Fix memory leak when initializing DH parameters in backend

  3. Avoid corner-case memory leak in SSL parameter processing.