Horton

Re: [HACKERS] Custom compression methods

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, David Steele <david@pgmasters.net>, Ildus Kurbangaliev <i.kurbangaliev@gmail.com>, Dmitry Dolgov <9erthalion6@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, pgsql-hackers@lists.postgresql.org
Date: 2021-03-19T17:44:26Z
Lists: pgsql-hackers 
On Fri, Mar 19, 2021 at 01:24:39PM -0400, Robert Haas wrote:
> On Fri, Mar 19, 2021 at 12:35 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > I sent offlist a couple of times but notice that the latest patch is missing
> > this bit around AC_CHECK_HEADERS, which apparently can sometimes cause
> > warnings on mac.
> >
> > ac_save_CPPFLAGS=$CPPFLAGS
> > CPPFLAGS="$LZ4_CFLAGS $CPPFLAGS"
> > AC_CHECK_HEADERS(lz4/lz4.h, [],
> >      [AC_CHECK_HEADERS(lz4.h, [], [AC_MSG_ERROR([lz4.h header file is required for LZ4])])])
> > CPPFLAGS=$ac_save_CPPFLAGS
> 
> Hmm, it's working for me on macOS Catalina without this. Why do we
> need it? Can you provide a patch that inserts it in the exact place
> you think it needs to go?

Working with one of Andrey's patches on another thread, he reported offlist
getting this message, resolved by this patch.  Do you see this warning during
./configure ?  The latest CI is of a single patch without the LZ4 stuff, so I
can't check its log.

configure: WARNING: lz4.h: accepted by the compiler, rejected by the preprocessor!                                                                                                                                                 
configure: WARNING: lz4.h: proceeding with the compiler's result                                                                                                                                                                   

-- 
Justin

Commits

  1. docs: Update TOAST storage docs for configurable compression.

  2. Further tweaking of pg_dump's handling of default_toast_compression.

  3. Fix interaction of TOAST compression with expression indexes.

  4. Tidy up more loose ends related to configurable TOAST compression.

  5. Short-circuit slice requests that are for more than the object's size.

  6. Mostly-cosmetic adjustments of TOAST-related macros.

  7. Remove useless configure probe for <lz4/lz4.h>.

  8. Error on invalid TOAST compression in CREATE or ALTER TABLE.

  9. docs: Fix omissions related to configurable TOAST compression.

  10. More code cleanup for configurable TOAST compression.

  11. Bring configure support for LZ4 up to snuff.

  12. Make compression.sql regression test independent of default.

  13. Use valid compression method in brin_form_tuple

  14. Fix up pg_dump's handling of per-attribute compression options.

  15. Allow configurable LZ4 TOAST compression.

  16. Fix inconsistencies in the code

  17. Mostly-cosmetic improvements in memory chunk header alignment coding.

  18. Allow numeric to use a more compact, 2-byte header in many cases.