Re: [PATCH] pgbench: improve \sleep meta command
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>
Cc: 'Fujii Masao' <masao.fujii@oss.nttdata.com>, 'miyake_kouta' <miyake_kouta@oss.nttdata.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-08T14:10:26Z
Lists: pgsql-hackers
On 2021-Mar-08, kuroda.hayato@fujitsu.com wrote: > Dear Fujii-san, Miyake-san > > > Isn't it better to accept even negative sleep time like currently pgbench does? > > Otherwise we always need to check the variable is a positive integer > > (for example, using \if command) when using it as the sleep time in \sleep > > command. That seems inconvenient. > > Both of them are acceptable for me. > But we should write down how it works when the negative value is input if we adopt. Not sleeping at all seems a good reaction (same as for zero, I guess.) -- Álvaro Herrera 39°49'30"S 73°17'W "XML!" Exclaimed C++. "What are you doing here? You're not a programming language." "Tell that to the people who use me," said XML.
Commits
-
pgbench: Improve error-handling in \sleep command.
- 8c6eda2d1c92 14.0 landed