Horton

Re: 011_crash_recovery.pl intermittently fails

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: tgl@sss.pgh.pa.us
Cc: thomas.munro@gmail.com, pg@bowt.ie, pgsql-hackers@lists.postgresql.org, craig.ringer@enterprisedb.com, robertmhaas@gmail.com
Date: 2021-03-08T00:39:15Z
Lists: pgsql-hackers 
At Fri, 05 Mar 2021 11:16:55 -0500, Tom Lane <tgl@sss.pgh.pa.us> wrote in 
> Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> > So I think we need to remove the shared_buffers setting for the
> > allows_streamig case in PostgresNode.pm
> 
> That would have uncertain effects on other TAP tests, so I'm disinclined
> to do it that way.  011_crash_recovery.pl doesn't actually use a standby
> server, so just removing its use of the allows_streaming option seems
> sufficient.
> 
> But, of course, first we need a fix for the bug we now know exists.
> Was anyone volunteering to make the patch?

Thomas' proposal sounds reasonable. If he is not going to do that for
now, I'm willing to work on that.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Remove recovery test 011_crash_recovery.pl

  2. Add a txid_status function.