Re: [PATCH] Bug fix in initdb output
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-02T14:32:48Z
Lists: pgsql-hackers
On 2021-Mar-02, Nitin Jadhav wrote: > > FWIW, I don't think that it is a good idea to come back to this > > decision for *nix platforms, so I would let it as-is, and use > > relative paths if initdb is called using a relative path. > > The command to be displayed either in absolute path or relative path > depends on the way the user is calling initdb. I agree with the above > comment to keep this behaviour as-is, that is if the initdb is called > using relative path, then it displays relative path otherwise absolute > path. Yeah. > > However, if you can write something that makes the path printed > > compatible for a WIN32 terminal while keeping the behavior > > consistent with other platforms, people would have no objections to > > that. > > I feel the patch attached above handles this scenario. Agreed. I'll push the original patch then. Thanks everybody for the discussion. -- Álvaro Herrera 39°49'30"S 73°17'W "Porque francamente, si para saber manejarse a uno mismo hubiera que rendir examen... ¿Quién es el machito que tendría carnet?" (Mafalda)
Commits
-
Use native path separators to pg_ctl in initdb
- f927767919e8 12.7 landed
- b52fd1e7c76c 13.3 landed
- ae1c1d84ea24 11.12 landed
- 926139dd04bb 10.17 landed
- 75dbfe4ca70d 14.0 landed
-
Have initdb display relative paths to start postmaster if used to invoke
- ee814b4511ec 8.0.0 cited