Horton

Re: [PATCH] Bug fix in initdb output

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Nitin Jadhav <nitinjadhavpostgres@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-01T21:18:41Z
Lists: pgsql-hackers 
On 2021-Mar-01, Juan José Santamaría Flecha wrote:

> Uhm, now that you point it out, an absolute path would make the message
> more consistent and reusable.

Well.  This code was introduced in a00c58314745, with discussion at
http://postgr.es/m/CAHeEsBeAe1FeBypT3E8R1ZVZU0e8xv3A-7BHg6bEOi=jZny2Uw@mail.gmail.com
which did not touch on the point of the pg_ctl path being relative or
absolute.  The previous decision to use relative seems to have been made
here in commit ee814b4511ec, which was backed by this discussion
https://www.postgresql.org/message-id/flat/200411020134.52513.peter_e%40gmx.net

So I'm not sure that anybody would love me if I change it again to
absolute.

-- 
Álvaro Herrera       Valdivia, Chile
Voy a acabar con todos los humanos / con los humanos yo acabaré
voy a acabar con todos (bis) / con todos los humanos acabaré ¡acabaré! (Bender)

Commits

  1. Use native path separators to pg_ctl in initdb

  2. Have initdb display relative paths to start postmaster if used to invoke