Re: Improvements and additions to COPY progress reporting

On Sun, Feb 21, 2021 at 08:10:09PM +0100, Matthias van de Meent wrote:
> Subject: [PATCH v9 1/3] Add progress-reported components for COPY progress
>  reporting

>  			/* Increment amount of processed tuples and update the progress */
>  	/* Increment amount of processed tuples and update the progress */

Ideally, this would say "number of processed tuples"

> Subject: [PATCH v9 2/3] Add backlinks to progress reporting documentation

I think these should say that they report their progress *in* the view (not
"to"):

> +    Each backend running <command>ANALYZE</command> will report its progress to
> +    the <structname>pg_stat_progress_analyze</structname> view. See

> +    Each backend running <command>CLUSTER</command> will report its progress to
> +    the <structname>pg_stat_progress_cluster</structname> view. See

> +    Each backend running <command>COPY</command> will report its progress to
> +    the <structname>pg_stat_progress_copy</structname> view. See

> +    Each backend running <command>CREATE INDEX</command> will report its
> +    progress to the <structname>pg_stat_progress_create_index</structname>

> +    Each backend running <command>REINDEX</command> will report its progress
> +    to the <structname>pg_stat_progress_create_index</structname> view. See

Like this one:

> +    Each backend running <command>VACUUM</command> without the
> +    <literal>FULL</literal> option will report its progress in the

I'm sorry I didn't include that in last week's message.  You could also write:

|"The progress of each backend running >ANALYZE< is reported in the >pg_stat_progress_analyze< view."

Looking at the existing docs:

https://www.postgresql.org/docs/devel/progress-reporting.html#COPY-PROGRESS-REPORTING
| OID of the table on which the COPY command is executed

Maybe it should say ".. is executing".  Or ".. being executed":
| OID of the table on which the COPY command is being executed

-- 
Justin